Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError when passing name to flow_to_workflow() #396

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 14, 2023

Closes #395.

62eb2c9 fix TypeError when passing name to flow_to_workflow()
bb3d972 test flow_to_workflow() with custom name

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #396 (bb3d972) into main (10aad48) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          19       19           
  Lines        1505     1505           
  Branches      374      374           
=======================================
  Hits         1503     1503           
  Misses          1        1           
  Partials        1        1           
Files Changed Coverage Δ
src/jobflow/managers/fireworks.py 100.00% <100.00%> (ø)

@janosh janosh merged commit 0fbabf3 into main Aug 14, 2023
8 checks passed
@janosh janosh deleted the fix-flow_to_workflow-name-type-err branch August 14, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Passing name to flow_to_workflow() raises TypeError
1 participant