Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataFile model #3992

Open
mathemancer opened this issue Oct 28, 2024 · 2 comments
Open

Remove DataFile model #3992

mathemancer opened this issue Oct 28, 2024 · 2 comments
Labels
needs: requirements The problem is clear and worth solving, but we're not yet sure of the best solution type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@mathemancer
Copy link
Contributor

Problem

We currently use a DataFile model to help handle uploading data for import into Mathesar. However,

  • The model isn't used after the import succeeds
  • It's overly complicated
  • It's risky to keep users data on the service beyond its usefulness

Proposed solution

We should revamp the import process so that the DataFile model isn't needed, and then remove it.

@mathemancer mathemancer added type: enhancement New feature or request needs: triage This issue has not yet been reviewed by a maintainer labels Oct 28, 2024
@mathemancer mathemancer added this to the Backlog milestone Oct 28, 2024
@mathemancer mathemancer added needs: requirements The problem is clear and worth solving, but we're not yet sure of the best solution work: backend Related to Python, Django, and simple SQL and removed needs: triage This issue has not yet been reviewed by a maintainer labels Oct 28, 2024
@aniketkulkarni17
Copy link
Contributor

Hi,
I would like to take up this issue, can you please assign it to me? Also, do we need to remove the DataFile model completely, or replace it with something else?

@mathemancer
Copy link
Contributor Author

As the issue says, we need to make it so that the import process works without a DataFile model. This implies replacing it with some functionality to upload a file from a user, and then import it into the DB satisfying the current UI without the model.

Re: assigning issues. We don't assign issues to new contributors. If you'd like to work on this you can, you should raise a PR with a solution, and we'll assign the issue to you while we review (if the solution looks viable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: requirements The problem is clear and worth solving, but we're not yet sure of the best solution type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
None yet
Development

No branches or pull requests

2 participants