Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantile min/max (i.e. p=0/1) doesn't work with a randomly order list of values #192

Open
sanjayginde opened this issue Nov 22, 2024 · 1 comment · May be fixed by #193
Open

Quantile min/max (i.e. p=0/1) doesn't work with a randomly order list of values #192

sanjayginde opened this issue Nov 22, 2024 · 1 comment · May be fixed by #193

Comments

@sanjayginde
Copy link

I noticed an issue that the quantile doesn't return the the property min or max quantile (where p = 0 || 1, respectively).

Checked out the code and looks like the quick checks aren't leveraging the sorted array.
sanjayginde added a commit to sanjayginde/fermat.js that referenced this issue Nov 22, 2024
@sanjayginde
Updated quantile to use sorted values for min and max
9abfc28 
Fixes mathigon#192
@sanjayginde sanjayginde linked a pull request Nov 22, 2024 that will close this issue
Open
@sanjayginde
Copy link
Author

Submitted PR #193 with a fix.

sanjayginde added a commit to sanjayginde/fermat.js that referenced this issue Nov 22, 2024
@sanjayginde
Updated quantile to use sorted values for min and max
e773310 
Fixes mathigon#192
sanjayginde added a commit to sanjayginde/fermat.js that referenced this issue Nov 22, 2024
@sanjayginde
Updated quantile to use sorted values for min and max
ef7f828 
Fixes mathigon#192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated quantile to use sorted values for min and max sanjayginde/fermat.js
1 participant
@sanjayginde