From a1551a9129b90fd11d779c866701bb9cfecbad7b Mon Sep 17 00:00:00 2001 From: Omar Dulaimi Date: Fri, 11 Jun 2021 00:02:43 +0300 Subject: [PATCH 1/4] fix cookies name in README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 60fe0e6d..da547c18 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ export async function getServerSideProps(ctx) { const cookies = nookies.get(ctx) // Set - nookies.set(ctx, 'fromGetInitialProps', 'value', { + nookies.set(ctx, 'getServerSideProps', 'value', { maxAge: 30 * 24 * 60 * 60, path: '/', }) From 0eca463ea8ab2ec46e8c60d6e266331ca31cbf3d Mon Sep 17 00:00:00 2001 From: Omar Dulaimi Date: Fri, 11 Jun 2021 00:05:14 +0300 Subject: [PATCH 2/4] use nookies instead of Kayu in CONTRIBUTING --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fdf1d5cf..b1823ab2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ :wave: -Thank you for reading this file! We'd love to see you help us make this package even better than it is. Since we are all working on Kayu in our free time, it's important that we follow some set of guidelines to make communication easier. Read this guideline to learn what we have in mind. +Thank you for reading this file! We'd love to see you help us make this package even better than it is. Since we are all working on nookies in our free time, it's important that we follow some set of guidelines to make communication easier. Read this guideline to learn what we have in mind. ### Language & Community @@ -18,7 +18,7 @@ Alright, so you want a new feature, right? Me too! Everyone wants a new feature This is a community driven project. Nobody is paid to work on it. Keep that in mind at all times. -To save people working on Kayu some time, first check other issues and discussions to see if somebody has requested a similar feature. It's a lot easier for us to prioritise tasks and implement a feature if we see a flourishing discussion in one of the feature requests. Share your thoughts, do research. +To save people working on nookies some time, first check other issues and discussions to see if somebody has requested a similar feature. It's a lot easier for us to prioritise tasks and implement a feature if we see a flourishing discussion in one of the feature requests. Share your thoughts, do research. We are inclined to read well structured arguments. If your request hasn't received much attention in say a month, try to do some research on it and share your findings. The more knowledge there already is, the easier (and faster) your feature will be implemented. From 85be7ba6a541a63a4a312ffe3ab1db40a44735a6 Mon Sep 17 00:00:00 2001 From: Omar Dulaimi Date: Fri, 11 Jun 2021 00:08:47 +0300 Subject: [PATCH 3/4] hyphenate reencoding for better readability --- packages/nookies/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nookies/src/index.ts b/packages/nookies/src/index.ts index f32a5503..50261dbd 100644 --- a/packages/nookies/src/index.ts +++ b/packages/nookies/src/index.ts @@ -93,7 +93,7 @@ export function setCookie( parsedCookie.name, parsedCookie.value, { - // we prevent reencoding by default, but you might override it + // we prevent re-encoding by default, but you might override it encode: (val: string) => val, ...(parsedCookie as cookie.CookieSerializeOptions), }, From 23ae5dc201a42ef2780cd6b5517e8dce7d1a2db6 Mon Sep 17 00:00:00 2001 From: Omar Dulaimi Date: Fri, 11 Jun 2021 03:22:30 +0300 Subject: [PATCH 4/4] match original cookie name --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index da547c18..0d7adefa 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ export async function getServerSideProps(ctx) { const cookies = nookies.get(ctx) // Set - nookies.set(ctx, 'getServerSideProps', 'value', { + nookies.set(ctx, 'fromGetServerSideProps', 'value', { maxAge: 30 * 24 * 60 * 60, path: '/', })