Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl Connection remaining open. #128

Closed
martin-neumann-gurus opened this issue Feb 9, 2024 · 0 comments · Fixed by #133
Closed

Curl Connection remaining open. #128

martin-neumann-gurus opened this issue Feb 9, 2024 · 0 comments · Fixed by #133

Comments

@martin-neumann-gurus
Copy link

In line 1955 you are doing a curl_init, but you do not close the connection. I think you should do a curl_close($ch); on line 1986. Also, if the connection fails it will stop the entire script. It might be interesting to implement a retry for a set number of times so that it does not stop the importing of the entire set in the middle of the thing. I adapted the routine for myself in order to do 10 retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants