-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace step with stairs and correct subplot_adjusts #112
Open
oscargus
wants to merge
1
commit into
matplotlib:master
Choose a base branch
from
oscargus:stairsandadjustments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
force-pushed
the
stairsandadjustments
branch
from
May 21, 2022 13:14
21e7a63
to
cafa722
Compare
jimustafa
suggested changes
May 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adjustments look good. For the stairs plot, the gridlines are on top of the stairs. Using ax.set_axisbelow(True)
can fix this.
Style suggestions:
|
oscargus
force-pushed
the
stairsandadjustments
branch
from
December 31, 2022 13:29
cafa722
to
8b63fb3
Compare
I just recalled this...
|
oscargus
force-pushed
the
stairsandadjustments
branch
from
December 31, 2022 13:42
8b63fb3
to
44f015c
Compare
Could you align y position on the grod for the stairs plot? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109
Closes #111
Hard to make the
subplot_adjusts
figure look really good, but here is the update one:Stairs illustration:
(Both are screen shots of the PDF.)
Not obvious which arguments should be used. I went with those that are (a bit) "special" for
stairs
.