Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same person can be defined multiple times #151

Open
reivilibre opened this issue Jan 13, 2023 · 0 comments
Open

The same person can be defined multiple times #151

reivilibre opened this issue Jan 13, 2023 · 0 comments

Comments

@reivilibre
Copy link
Contributor

public async findPeopleWithId(personId: string): Promise<IPerson[]> { is awkward enough on its own, but what I only just realised is that a person may appear in multiple events with different roles.

This means that having the role on IPerson is pretty poor ­— I'm really not a fan of having multiple people per ID that correspond to the same physical human being acting in multiple capacities. Some denormalisation would be appreciated.

reivilibre added a commit that referenced this issue Jan 16, 2023
reivilibre added a commit that referenced this issue Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant