Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popping out widget and maximising it does not change audio settings #51

Closed
kittykat opened this issue Nov 25, 2021 · 5 comments
Closed
Assignees
Labels
FOSDEM Needed for FOSDEM

Comments

@kittykat
Copy link

Audio settings should remain the same regardless of how the user interacts with widget location or sizing.

(This needs to be tested to confirm that this is still an issue)

@kittykat kittykat added the FOSDEM Needed for FOSDEM label Nov 25, 2021
@squahtx
Copy link
Contributor

squahtx commented Jan 17, 2022

I'm assuming this is about the video player and not Jitsi.
Popping out the widget loads a completely new instance of the widget, which is why it resets. We might be able to remember the audio settings in localStorage.

@squahtx
Copy link
Contributor

squahtx commented Jan 17, 2022

localStorage only works while third party tracking is allowed, and only works for maximise.

Leaving this issue alone for now.

@squahtx
Copy link
Contributor

squahtx commented Jan 17, 2022

Filed the maximise issue as element-hq/element-web#20596

@kittykat
Copy link
Author

kittykat commented Feb 1, 2022

Assigning to @jaywink as this has been fixed upstream and we just need to make sure it makes it into our downstream app

@kittykat
Copy link
Author

kittykat commented Feb 3, 2022

Fixed, but #109 is an issue now and #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FOSDEM Needed for FOSDEM
Projects
None yet
Development

No branches or pull requests

3 participants