Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfilled messages are replayed after messages triggering the backfill #1673

Open
progval opened this issue Mar 6, 2023 · 1 comment
Open

Comments

@progval
Copy link
Contributor

progval commented Mar 6, 2023

When the homeserver the bridge runs on didn't get messages A and B from user 1 for whatever reason, and user 2 sends message C that gets through (eg. because user 2 is not on the same HS as 1), the bridge sends C first, then B and A thanks to backfilling from 2's homeserver.

I have only observed this when the backfill included a join of user 1 puppet, so it's possible that it's another instance of #1572 and the order would be C, then A then B if #1572 got fixed.

@progval
Copy link
Contributor Author

progval commented Mar 7, 2023

I have only observed this when the backfill included a join of user 1 puppet, so it's possible that it's another instance of #1572 and the order would be C, then A then B if #1572 got fixed.

yeah, turns out it is

@progval progval changed the title Backfilled messages are replayed in the wrong order Backfilled messages are replayed after messages triggering the backfill Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant