-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply to edited message does not take edits into account #1836
Comments
Related to edited messages, there's a FIXME comment at https://github.com/matrix-org/matrix-appservice-irc/blob/develop/src/bridge/MatrixHandler.ts#L1086 which can be removed, as since MSC3925 fetching the original event will give you the initial version's content (with later edit events in Before that change, fetching the reply source event from the homeserver would've returned a content.body with edits applied. |
Also minor issue that for the fetched event, only the raw |
In case of an |
I think that might be intentional. When someone quotes a message manually edits are usually not taken into account but this is just to restate the context.. But this might be good to have anyway |
Getting the source text of a replied to event relies on either finding the original message in the
eventCache
, or failing that, fetching it from the homeserver. In neither of those cases, edits to the message are taken into account.Relevant code https://github.com/matrix-org/matrix-appservice-irc/blob/develop/src/bridge/MatrixHandler.ts#L1317
When the bridge uses the long reply template, this will always use the old text for the quote
The text was updated successfully, but these errors were encountered: