From 789040d22f8e1afeda1be9cfd838ae1118ef7c8f Mon Sep 17 00:00:00 2001
From: Quentin Gliech <quenting@element.io>
Date: Tue, 12 Sep 2023 11:16:48 +0200
Subject: [PATCH] graphql: Fix the createOauth2Session mutation not persisting
 the changes to the database

---
 crates/graphql/src/mutations/oauth2_session.rs |  2 ++
 crates/handlers/src/graphql/tests.rs           | 18 +++++++++++++++++-
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/crates/graphql/src/mutations/oauth2_session.rs b/crates/graphql/src/mutations/oauth2_session.rs
index a9b2d171f..0e604a113 100644
--- a/crates/graphql/src/mutations/oauth2_session.rs
+++ b/crates/graphql/src/mutations/oauth2_session.rs
@@ -199,6 +199,8 @@ impl OAuth2SessionMutations {
             Some(refresh_token)
         };
 
+        repo.save().await?;
+
         Ok(CreateOAuth2SessionPayload {
             session,
             access_token: access_token.access_token,
diff --git a/crates/handlers/src/graphql/tests.rs b/crates/handlers/src/graphql/tests.rs
index 6033a7ed8..4a5d15745 100644
--- a/crates/handlers/src/graphql/tests.rs
+++ b/crates/handlers/src/graphql/tests.rs
@@ -16,7 +16,10 @@ use axum::http::Request;
 use hyper::StatusCode;
 use mas_data_model::{AccessToken, Client, TokenType, User};
 use mas_router::SimpleRoute;
-use mas_storage::{oauth2::OAuth2ClientRepository, RepositoryAccess};
+use mas_storage::{
+    oauth2::{OAuth2AccessTokenRepository, OAuth2ClientRepository},
+    RepositoryAccess,
+};
 use oauth2_types::{
     registration::ClientRegistrationResponse,
     requests::AccessTokenResponse,
@@ -551,4 +554,17 @@ async fn test_oauth2_client_credentials(pool: PgPool) {
     assert!(response.errors.is_empty(), "{:?}", response.errors);
     assert!(response.data["createOauth2Session"]["refreshToken"].is_null());
     assert!(response.data["createOauth2Session"]["accessToken"].is_string());
+
+    let token = response.data["createOauth2Session"]["accessToken"]
+        .as_str()
+        .unwrap();
+
+    // We should find this token in the database
+    let mut repo = state.repository().await.unwrap();
+    let token = repo
+        .oauth2_access_token()
+        .find_by_token(token)
+        .await
+        .unwrap();
+    assert!(token.is_some());
 }