Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private messages in MUC don't get sent to the right resource if it contains certain characters #268

Open
maranda opened this issue Jul 29, 2021 · 0 comments · May be fixed by #271
Open

Private messages in MUC don't get sent to the right resource if it contains certain characters #268

maranda opened this issue Jul 29, 2021 · 0 comments · May be fixed by #271
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@maranda
Copy link

maranda commented Jul 29, 2021

Describe the bug
Bifrost seems to be mangling and/or prepping incorrectly certain characters when sending stanzas.

To Reproduce
Steps to reproduce the behavior:

  1. Join [email protected]
  2. Attempt to privately message jonas’‎
  3. Message gets sent to "jonas 19" which doesn't exist

Expected behavior
The message should be sent to jonas’

Additional context
Some logs about the issue

Bifrost:
Jul-29 08:19:05.390 INFO MatrixEventHandler Handling IM message
Jul-29 08:19:05.391 INFO MatrixEventHandler Sending IM to [email protected]/jonas 19
Jul-29 08:19:05.392 INFO XmppJsGateway Looking up possible gateway: @maranda:aria-net.org [email protected]/jonas 19 [email protected]

XMPP Server:
Jul 29 08:19:05 jcp55df4cc03bb0 debug Received[component]:
Jul 29 08:19:05 s2sout55df4b10b5c0 debug sending:
Jul 29 08:19:05 s2sout55df4b10b5c0 debug Received[s2sout]:

@maranda maranda changed the title Private messages don't get sent to the right resource if it contains certain characters Private messages in MUC don't get sent to the right resource if it contains certain characters Jul 29, 2021
@tadzik tadzik self-assigned this Jul 30, 2021
@tadzik tadzik mentioned this issue Jul 30, 2021
Open
tadzik added a commit that referenced this issue Jul 30, 2021
@tadzik
Fix not being able to DM users with non-ascii usernames
3450988 
Remote usernames with multibyte characters in them currently get encoded
into mxids in a way that may result in information loss
(see matrix-org/matrix-appservice-bridge#346).

This makes it impossible to reach some users by MXID alone, so this
makes it lookup the MXID in the user store, which contains the original,
unmangled username.

Fixes GH-268.
@tadzik tadzik linked a pull request Jul 30, 2021 that will close this issue
Open
tadzik added a commit that referenced this issue Aug 2, 2021
@tadzik
Fix not being able to DM users with non-ascii usernames
d83aed1 
Remote usernames with multibyte characters in them currently get encoded
into mxids in a way that may result in information loss
(see matrix-org/matrix-appservice-bridge#346).

This makes it impossible to reach some users by MXID alone, so this
makes it lookup the MXID in the user store, which contains the original,
unmangled username.

Fixes GH-268.
maranda added a commit to maranda/matrix-bifrost that referenced this issue Nov 10, 2021
@maranda
Merge remote-tracking branch 'upstream/tadzik/matrix-orggh-268/fix-no…
c4de4fe 
…n-ascii-dms' into aria-net-bifrost
@jaller94 jaller94 added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. label May 20, 2022
@tadzik tadzik removed their assignment Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix not being able to DM users with non-ascii usernames matrix-org/matrix-bifrost
3 participants
@tadzik @maranda @jaller94