Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should GitLab note updates be handled? #958

Open
zecakeh opened this issue Jun 29, 2024 · 0 comments
Open

How should GitLab note updates be handled? #958

zecakeh opened this issue Jun 29, 2024 · 0 comments

Comments

@zecakeh
Copy link
Contributor

zecakeh commented Jun 29, 2024

GitLab has a webhook for notes "updates", i.e. when a comment in an MR or issue is edited. Currently the code doesn't make a difference when it receives a note update or a note creation, so it appears as a new comment which seems wrong.

Logically, we should use a replacement relation to edit the first message. Firstly, that would mean that we need to keep track of the event ID for every note. Secondly, given that MR review comments are batched, it becomes a bit more complicated to construct the edit. We would need to keep track of every note that was sent in an event, and probably require to fetch the other notes in the event to have the full edit content.

We could also choose the easy way out and ignore edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant