Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

The http(s)LinkScheme setting is too simplistic #661

Open
m8nmueller opened this issue Apr 28, 2020 · 0 comments · May be fixed by #662
Open

The http(s)LinkScheme setting is too simplistic #661

m8nmueller opened this issue Apr 28, 2020 · 0 comments · May be fixed by #662

Comments

@m8nmueller
Copy link

The MXKAppSetting properties httpLinkScheme and httpsLinkScheme allow for the use of a third-party browser to open links. This works great for Chrome but not for Firefox which expects a URL of the form firefox://open-url?url=encodedUrl where encodedUrl is the target url encoded as query param (this is done by addingPercentEncoding(withAllowedCharacters: urlQueryAllowed).

This can become quite complex (as is at Telegram) because some browser expect a format like dolphin://http://whatever.com or yandexbrowser-open-url://escapedUrl where escapedUrl is url-host escaped.

While I think, the latter stuff is unneeded, the support for Firefox would be nice and is also asked for at Riot. I will work on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant