diff --git a/src/crypto/index.ts b/src/crypto/index.ts index 6610f8621e2..4d96216be07 100644 --- a/src/crypto/index.ts +++ b/src/crypto/index.ts @@ -130,7 +130,12 @@ export function isCryptoAvailable(): boolean { return Boolean(global.Olm); } -const MIN_FORCE_SESSION_INTERVAL_MS = 60 * 60 * 1000; +// minimum time between attempting to unwedge an Olm session, if we succeeded +// in creating a new session +const MIN_FORCE_SESSION_INTERVAL_MS = 60 * 60 * 1000; // 1 hour +// minimum time between attempting to unwedge an Olm session, if we failed +// to create a new session +const FORCE_SESSION_RETRY_INTERVAL_MS = 5 * 60 * 1000; // 5 minutes interface IInitOpts { exportedOlmDevice?: IExportedDevice; @@ -390,7 +395,7 @@ export class Crypto extends TypedEventEmitter } = {}; - // The timestamp of the last time we forced establishment + // The timestamp of the minimum time at which we will retry forcing establishment // of a new session for each device, in milliseconds. // { // userId: { @@ -398,7 +403,7 @@ export class Crypto extends TypedEventEmitter> = new MapWithDefault( + private forceNewSessionRetryTime: MapWithDefault> = new MapWithDefault( () => new MapWithDefault(() => 0), ); @@ -3592,25 +3597,23 @@ export class Crypto extends TypedEventEmitter Date.now()) { + const forceNewSessionRetryTimeDevices = this.forceNewSessionRetryTime.getOrCreate(sender); + const forceNewSessionRetryTime = forceNewSessionRetryTimeDevices.getOrCreate(deviceKey); + if (forceNewSessionRetryTime > Date.now()) { logger.debug( - "New session already forced with device " + - sender + - ":" + - deviceKey + - " at " + - lastNewSessionForced + - ": not forcing another", + `New session already forced with device ${sender}:${deviceKey}: ` + + `not forcing another until at least ${new Date(forceNewSessionRetryTime).toUTCString()}`, ); await this.olmDevice.recordSessionProblem(deviceKey, "wedged", true); retryDecryption(); return; } + // make sure we don't retry to unwedge too soon even if we fail to create a new session + forceNewSessionRetryTimeDevices.set(deviceKey, Date.now() + FORCE_SESSION_RETRY_INTERVAL_MS); + // establish a new olm session with this device since we're failing to decrypt messages // on a current session. // Note that an undecryptable message from another device could easily be spoofed - @@ -3631,7 +3634,7 @@ export class Crypto extends TypedEventEmitter