This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Replace Uniffi fork when a new version lands #783
Labels
A-Rich-Text-Editor
good first issue
Good for newcomers
iOS
T-Enhancement
Improvement or feature request
Comments
Currently blocked because of: #786 Replacing the Uniffi fork will only be possible when duplicated symbols issues are fixed: mozilla/uniffi-rs#1670 |
aringenbach
changed the title
Replace Uniffi fork when a new version with library mode crate type fix lands
Replace Uniffi fork when a new version lands
Aug 25, 2023
Is this unblocked now that mozilla/uniffi-rs#1670 is resolved by mozilla/uniffi-rs#1735 ? |
Seems like there was no release yet, we could though try to use a commit from the main branch. |
jonnyandrew
added
T-Defect
T-Enhancement
Improvement or feature request
good first issue
Good for newcomers
and removed
T-Defect
labels
Oct 5, 2023
nimau
added a commit
that referenced
this issue
Nov 23, 2023
nimau
added a commit
that referenced
this issue
Nov 23, 2023
nimau
added a commit
that referenced
this issue
Nov 23, 2023
nimau
added a commit
that referenced
this issue
Nov 24, 2023
Remove uniffi fork from dependencies (#783)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-Rich-Text-Editor
good first issue
Good for newcomers
iOS
T-Enhancement
Improvement or feature request
Since moving to a dynamic Swift library (#782), symbols won't clash anymore. So the only reason to keep our fork of
uniffi-rs
is a library mode build fix around crate types that is unreleased yet, see #768.The required fix should be available in uniffi version
0.24.4
/0.25.0
. We can then replace the configuration for the fork atmatrix-rich-text-editor/Cargo.toml
Line 19 in d76a9f8
The text was updated successfully, but these errors were encountered: