Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Replace Uniffi fork when a new version lands #783

Closed
aringenbach opened this issue Aug 23, 2023 · 3 comments · Fixed by #889
Closed

Replace Uniffi fork when a new version lands #783

aringenbach opened this issue Aug 23, 2023 · 3 comments · Fixed by #889
Labels
A-Rich-Text-Editor good first issue Good for newcomers iOS T-Enhancement Improvement or feature request

Comments

@aringenbach
Copy link
Contributor

Since moving to a dynamic Swift library (#782), symbols won't clash anymore. So the only reason to keep our fork of uniffi-rs is a library mode build fix around crate types that is unreleased yet, see #768.

The required fix should be available in uniffi version 0.24.4 / 0.25.0. We can then replace the configuration for the fork at

# We use a custom version of Uniffi that renames symbols that might clash
with the standard new version of uniffi.

@aringenbach
Copy link
Contributor Author

aringenbach commented Aug 25, 2023

Currently blocked because of: #786

Replacing the Uniffi fork will only be possible when duplicated symbols issues are fixed: mozilla/uniffi-rs#1670

@aringenbach aringenbach changed the title Replace Uniffi fork when a new version with library mode crate type fix lands Replace Uniffi fork when a new version lands Aug 25, 2023
@jonnyandrew
Copy link
Contributor

Is this unblocked now that mozilla/uniffi-rs#1670 is resolved by mozilla/uniffi-rs#1735 ?

@aringenbach
Copy link
Contributor Author

Seems like there was no release yet, we could though try to use a commit from the main branch.
But yeah from what I'm reading it seems that there shouldn't be anything preventing us from going back to the official repository (as long as both the fix for library path & this one are part of whatever version we are using)

@jonnyandrew jonnyandrew added T-Defect T-Enhancement Improvement or feature request good first issue Good for newcomers and removed T-Defect labels Oct 5, 2023
nimau added a commit that referenced this issue Nov 24, 2023
Remove uniffi fork from dependencies (#783)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Rich-Text-Editor good first issue Good for newcomers iOS T-Enhancement Improvement or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants