Can't type numbers with some keyboards

[jonnyandrew]

See element-hq/element-x-android#1415

[jonnyandrew]

For anyone wanting to help with this issue, here are some observations from when I looked at it:

The problem seems to be related to the custom InputConnection and/or how it's used by the input method. The input connection expects the input method to call a combination of setComposingText(), commitText() and possibly others to update the current 'composition' (which is usually a word).

IIRC, the issue happens when there is a number (let's say "1") being composed. After pressing space with certain keyboards, the keyboard will call commitText(" ") rather than commitText("1 "), causing the number to be replaced by a space.

The class uses an unusual mixture of inheritance and delegation which makes the problem difficult to debug but also may be related to the issue itself.

matrix-rich-text-editor/platforms/android/library/src/main/java/io/element/android/wysiwyg/inputhandlers/InterceptInputConnection.kt

Lines 22 to 26 in 57d97a7

	internal class InterceptInputConnection(
	private val baseInputConnection: InputConnection,
	private val editorEditText: TextView,
	private val viewModel: EditorViewModel,
	) : BaseInputConnection(editorEditText, true) {

matrix-rich-text-editor/platforms/android/library/src/main/java/io/element/android/wysiwyg/EditorEditText.kt

Lines 190 to 196 in 57d97a7

	override fun onCreateInputConnection(outAttrs: EditorInfo): InputConnection {
	val baseInputConnection = requireNotNull(super.onCreateInputConnection(outAttrs))
	val inputConnection =
	InterceptInputConnection(baseInputConnection, this, viewModel)
	this.inputConnection = inputConnection
	return inputConnection
	}

[jonnyandrew]

Fixed in #878