This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Loading HTML containing @room creates nested links and eventually crashes
#855
Labels
Comments
jmartinesp
changed the title
@room creates nested links@room creates nested links and eventually crashes
|
Seems like it is this code: fn convert_text<S: UnicodeString>(
text: &str,
node: &mut ContainerNode<S>,
is_inside_code_block: bool,
) {
if is_inside_code_block {
let text_nodes: Vec<_> = text.split('\n').collect();
let text_nodes_len = text_nodes.len();
for (i, str) in text_nodes.into_iter().enumerate() {
let is_nbsp = str == "\u{A0}" || str == " ";
if !str.is_empty() && !is_nbsp {
let text_node = DomNode::new_text(str.into());
node.append_child(text_node);
}
if i + 1 < text_nodes_len {
node.append_child(DomNode::new_line_break());
}
}
} else {
let contents = text;
let is_nbsp = contents == "\u{A0}" || contents == " ";
if is_nbsp {
return;
}
// Trim any surrounding indentation
let surrounding_indent =
Regex::new(r"^(\s*\n\s*)+|(\s*\n\s*)+$").unwrap();
let contents = &surrounding_indent.replace_all(contents, "");
// Replace any internal indentation with a single space
let internal_indent = Regex::new(r"s*\n\s*").unwrap();
let contents = &internal_indent.replace_all(contents, " ");
for (i, part) in contents.split("@room").enumerate() {
if i > 0 {
node.append_child(DomNode::Mention(
DomNode::new_at_room_mention(vec![]),
));
}
if !part.is_empty() {
node.append_child(DomNode::new_text(part.into()));
}
}
}
}We need to do that last part only if we are not parsing an already created mention. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I could only test this on Android, for now, but the steps I took were:
@roomin the example editor, get a pill.This can also be reproduced by rotating the phone, anything that causes an Activity (and views) re-creation.
In the logs, I see, for each state:
@room |<a data-mention-type="at-room" href="#" contenteditable="false">@room</a> |<a data-mention-type="at-room" contenteditable="false" href="#"><a data-mention-type="at-room" href="#" contenteditable="false">@room</a>|</a>And finally:
The text was updated successfully, but these errors were encountered: