crypto: Replace the implementation of get_verification_state with SenderDataFinder #3772
Conversation
andybalaam
changed the title
andybalaam
force-pushed
the
andybalaam/lazily-populate-sender-data
branch
from
0d9cf72 to
282320f
Compare
|
Pasting the patch for 282320f in case it ever disappears. This code was temporary code to validate the |
andybalaam
force-pushed
the
andybalaam/lazily-populate-sender-data
branch
from
282320f to
285f3ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
==========================================
- Coverage 84.09% 84.01% -0.08%
==========================================
Files 259 259
Lines 27109 27145 +36
==========================================
+ Hits 22797 22806 +9
- Misses 4312 4339 +27 ☔ View full report in Codecov by Sentry. |
| ) | ||
| } | ||
| } | ||
| SenderData::UnknownDevice { owner_check_failed: true, .. } => ( |
There was a problem hiding this comment.
Shame that we can't put this into a From implementation, would cement down the fact that these two are parts of the same coin.
There was a problem hiding this comment.
Yeah I considered that, and in a future PR I moved it into a function, but it's (SenderData, is_imported) -> (VerificationState, DeviceId) so it doesn't quite fit.
There was a problem hiding this comment.
Yeah, I saw that is_imported messes everything up 😢.
This avoids repeating equivalent code.
andybalaam
force-pushed
the
andybalaam/lazily-populate-sender-data
branch
from
89bcd6c to
fedd813
Compare
Replace the implementation of
get_verification_statewithSenderDataFinder, since they are now equivalent.Part of #3751
As part of developing this PR, I created (and then removed) this commit: 282320f which proves that for every case, converting from
SenderDataFinder's result into aVerificationStateand anOption<DeviceId>produces the same result as the oldget_verification_statecode, so we can safely replace it.