refactor(event cache store): use a single transaction to handle all linked chunk updates at once #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inked chunk updates at once Instead of one transaction per update. This ensures that if a single update fails, then none is taken into account.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4395 +/- ##
=======================================
Coverage 85.16% 85.17%
=======================================
Files 281 281
Lines 30924 30886 -38
=======================================
- Hits 26337 26306 -31
+ Misses 4587 4580 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of one transaction per update. This ensures that if a single update fails, then none is taken into account.
The test triggers a unique constraint violation. Before the patch, it would still contain a single chunk (the first one), while after the patch, it contains none.
Part of #3280.