Skip to content

Conversation

@jmartinesp
Copy link
Contributor

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2025

CodSpeed Performance Report

Merging #5864 will not alter performance

Comparing fix/sending-read-receipts-in-threads (6eec020) with main (9ab886f)

Summary

✅ 50 untouched

@jmartinesp jmartinesp force-pushed the fix/sending-read-receipts-in-threads branch 2 times, most recently from 07141d7 to ef9278f Compare November 13, 2025 15:34
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.60%. Comparing base (9ab886f) to head (6eec020).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rates/matrix-sdk-ui/src/timeline/controller/mod.rs 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5864      +/-   ##
==========================================
+ Coverage   88.59%   88.60%   +0.01%     
==========================================
  Files         363      363              
  Lines      102888   102923      +35     
  Branches   102888   102923      +35     
==========================================
+ Hits        91153    91195      +42     
+ Misses       7496     7485      -11     
- Partials     4239     4243       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…n a thread

Previously, this used the latest event in the thread as the event to mark as read, while this is not right if we're in a context that hides thread events
@jmartinesp jmartinesp force-pushed the fix/sending-read-receipts-in-threads branch from ef9278f to 635313a Compare November 13, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants