Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive shouldn't have jump links into the future - You can't view the history of a room on a future day error #215

Open
Miepee opened this issue May 5, 2023 · 4 comments
Labels
A-archive-room-view The view to look at a room day by day in the archive help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. T-Enhancement New feature or request

Comments

@Miepee
Copy link

Miepee commented May 5, 2023

When viewing the current day of messages, the page still has a jump link to the next activity in the room. This means it's very easy to to run into the You can't view the history of a room on a future day error by just clicking the jump link in the UI.


As discussed in Matrix Public Archive room

@MadLittleMods MadLittleMods added T-Enhancement New feature or request A-archive-room-view The view to look at a room day by day in the archive labels May 5, 2023
@MadLittleMods MadLittleMods changed the title Easy to achieve "you can't see future history" error Archive shouldn't have jump links into the future - "you can't see future history" error May 5, 2023
@MadLittleMods MadLittleMods changed the title Archive shouldn't have jump links into the future - "you can't see future history" error Archive shouldn't have jump links into the future - You can't view the history of a room on a future day error May 5, 2023
@MadLittleMods
Copy link
Contributor

Thanks for reporting this foot-gun scenario @Miepee!

We could go with the simple solution of simply not showing the next activity jump link. But this could also be a little more nuanced since you can leave a tab open until the day rolls over and perhaps you do want to jump then.

Or it's still the same day and you just want to refresh the page to see new content.

Perhaps when viewing the current day, we could go with a simple solution where the next activity summary tile would just say: "Refresh the page to see new content ⏩". Although I wish the phrasing could encompass the fact that there might not be new content and we don't know.

@Miepee
Copy link
Author

Miepee commented May 5, 2023

Personally like the "Refresh the page" idea.

@bkil
Copy link

bkil commented May 30, 2023

Hitting this exception by a user unintentionally is really scary and probably not very good for SEO either. Could we perhaps improve how this error condition is presented even?

But also, matrix-static hid the paging button and replaced it with the following text in such a case:

There are no newer messages yet.

I could hardly imagine people keeping the same page on matrix-archive open for days as a substitute for running a matrix client, but if this is a use case to cover, we could include a different kind of conditional link, such as:

There are no newer messages as of 13:37. [Check for newer messages] 🔃

Pressing that button could result in one of:

Related: #245

@MadLittleMods MadLittleMods added the help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. label May 30, 2023
@MadLittleMods
Copy link
Contributor

There are no newer messages as of 13:37. [Check for newer messages] 🔃

@bkil This sounds like another decent option to me 👍

Some combination with "Refresh the page to see new content ⏩" is probably the way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-archive-room-view The view to look at a room day by day in the archive help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. T-Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants