Autolinking should not stop when encountering first &

[bkil]

Autolinking should not stop when encountering first &

Example

• https://archive.matrix.org/r/securemessagingapps:matrix.org/date/2023/05/30?at=$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI

{
  "content": {
    "body": "Excellent. Seems like some (most?) clients would probably fail to scroll back to this time in history:\n* https://matrix.to/#/!sOLQNHloevPHIEWcYN:matrix.org/$vofnzkokpJxtvNEGbZN9fWsCxFJc9UX2CIsQj4ZTW38?via=matrix.org&via=tchncs.de&via=t2bot.io",
    "format": "org.matrix.custom.html",
    "formatted_body": "<p>Excellent. Seems like some (most?) clients would probably fail to scroll back to this time in history:</p>\n<ul>\n<li>https://matrix.to/#/!sOLQNHloevPHIEWcYN:matrix.org/$vofnzkokpJxtvNEGbZN9fWsCxFJc9UX2CIsQj4ZTW38?via=matrix.org&amp;via=tchncs.de&amp;via=t2bot.io</li>\n</ul>\n",
    "msgtype": "m.text"
  },
  "origin_server_ts": 1685370132404,
  "sender": "@bkil:grin.hu",
  "type": "m.room.message",
  "unsigned": {
    "m.relations": {
      "m.thread": {
        "latest_event": {
          "content": {
            "body": "mine fails. And I had same issue several times today.",
            "m.relates_to": {
              "event_id": "$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI",
              "is_falling_back": true,
              "m.in_reply_to": {
                "event_id": "$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI"
              },
              "rel_type": "m.thread"
            },
            "msgtype": "m.text"
          },
          "origin_server_ts": 1685370490952,
          "room_id": "!sOLQNHloevPHIEWcYN:matrix.org",
          "sender": "@iam:pavli.cc",
          "type": "m.room.message",
          "unsigned": {},
          "event_id": "$AlmvB1jPcCIn3Tdv-izDFzQ1-P5k3sPcHZ0Kogkc_so",
          "user_id": "@iam:pavli.cc"
        },
        "count": 1,
        "current_user_participated": false
      }
    }
  },
  "event_id": "$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI",
  "room_id": "!sOLQNHloevPHIEWcYN:matrix.org"
}

[MadLittleMods]

@bkil Can you give an example? (link and event JSON)

I'm unable to reproduce:

[bkil]

@MadLittleMods

• https://archive.matrix.org/r/securemessagingapps:matrix.org/date/2023/05/30?at=$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI

{
  "content": {
    "body": "Excellent. Seems like some (most?) clients would probably fail to scroll back to this time in history:\n* https://matrix.to/#/!sOLQNHloevPHIEWcYN:matrix.org/$vofnzkokpJxtvNEGbZN9fWsCxFJc9UX2CIsQj4ZTW38?via=matrix.org&via=tchncs.de&via=t2bot.io",
    "format": "org.matrix.custom.html",
    "formatted_body": "<p>Excellent. Seems like some (most?) clients would probably fail to scroll back to this time in history:</p>\n<ul>\n<li>https://matrix.to/#/!sOLQNHloevPHIEWcYN:matrix.org/$vofnzkokpJxtvNEGbZN9fWsCxFJc9UX2CIsQj4ZTW38?via=matrix.org&amp;via=tchncs.de&amp;via=t2bot.io</li>\n</ul>\n",
    "msgtype": "m.text"
  },
  "origin_server_ts": 1685370132404,
  "sender": "@bkil:grin.hu",
  "type": "m.room.message",
  "unsigned": {
    "m.relations": {
      "m.thread": {
        "latest_event": {
          "content": {
            "body": "mine fails. And I had same issue several times today.",
            "m.relates_to": {
              "event_id": "$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI",
              "is_falling_back": true,
              "m.in_reply_to": {
                "event_id": "$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI"
              },
              "rel_type": "m.thread"
            },
            "msgtype": "m.text"
          },
          "origin_server_ts": 1685370490952,
          "room_id": "!sOLQNHloevPHIEWcYN:matrix.org",
          "sender": "@iam:pavli.cc",
          "type": "m.room.message",
          "unsigned": {},
          "event_id": "$AlmvB1jPcCIn3Tdv-izDFzQ1-P5k3sPcHZ0Kogkc_so",
          "user_id": "@iam:pavli.cc"
        },
        "count": 1,
        "current_user_participated": false
      }
    }
  },
  "event_id": "$5cQZRtG9bsleXZI2x-s6wEDfeZ5B1nC_jEvOwpA-VdI",
  "room_id": "!sOLQNHloevPHIEWcYN:matrix.org"
}

[MadLittleMods]

Thanks for the extra details @bkil!

This looks like a problem with the server-side rendered (SSR) HTML of an event with formatted_body and fixes itself after the the client-side JavaScript kicks in and fixes the link.

Server-side rendered HTML:

<div class="Timeline_messageBody">
   <!--node binding placeholder-->
   <p>Excellent. Seems like some (most?) clients would probably fail to scroll back to this time in history:</p>
   <ul>
      <li><a rel="noopener" target="_blank" class="link" href="https://matrix.to/#/!sOLQNHloevPHIEWcYN:matrix.org/$vofnzkokpJxtvNEGbZN9fWsCxFJc9UX2CIsQj4ZTW38?via=matrix.org">https://matrix.to/#/!sOLQNHloevPHIEWcYN:matrix.org/$vofnzkokpJxtvNEGbZN9fWsCxFJc9UX2CIsQj4ZTW38?via=matrix.org</a>&amp;via=tchncs.de&amp;via=t2bot.io</li>
   </ul>
   <time>2:22 PM</time>
</div>

This would be the server-side rendered output of Hydrogen but looks like this isn't a problem with Hydrogen itself because it seems to work out fine in the browser context.