Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The units.parse builtin should not round to the value to the nearest integer #43

Open
sandhose opened this issue Aug 2, 2022 · 0 comments
Open

The units.parse builtin should not round to the value to the nearest integer #43

sandhose opened this issue Aug 2, 2022 · 0 comments
Labels
builtins Related to builtins implementation

Comments

@sandhose
Copy link
Member

sandhose commented Aug 2, 2022

units.parse("1.0005k") outputs 1000 instead of 1000.5. This is inconsistent with the Go implementation: https://play.openpolicyagent.org/p/TBQcYuuaQr

More context here: #30 (review)
@sandhose sandhose added the builtins Related to builtins implementation label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builtins Related to builtins implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sandhose