Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Reduce any possible duplication in logic in create_new_client_event #14688

Closed
H-Shay opened this issue Dec 16, 2022 · 1 comment
Closed

Reduce any possible duplication in logic in create_new_client_event #14688

H-Shay opened this issue Dec 16, 2022 · 1 comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@H-Shay
Copy link
Contributor

H-Shay commented Dec 16, 2022

As was noted in the discussion of #14575, it appears that some of the logic added to support the batch creation of events when creating a room could potentially be overlapping/redundant of the logic already in place to support the /batch_send endpoint. Investigate whether this is so, and reduce any duplicate logic if that is the case.
@H-Shay H-Shay added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Dec 16, 2022
@H-Shay H-Shay mentioned this issue Dec 16, 2022
Merged
@H-Shay
Copy link
Contributor Author

H-Shay commented Feb 6, 2023

I think this has been fixed by #14675

@H-Shay H-Shay closed this as completed Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@H-Shay