Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Declare support for Matrix v1.7 #15661

Closed
12 tasks done
clokep opened this issue May 23, 2023 · 7 comments · Fixed by #16707
Closed
12 tasks done

Declare support for Matrix v1.7 #15661

clokep opened this issue May 23, 2023 · 7 comments · Fixed by #16707
Assignees
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented May 23, 2023

See the changelog (note that I stripped out spec clarifications).

Client-Server API

New Endpoints

Backwards Compatible Changes

Application Service API

New Endpoints

Backwards Compatible Changes


Depends on #15089.

@clokep clokep added A-Spec-Compliance places where synapse does not conform to the spec S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 23, 2023
@clokep
Copy link
Member Author

clokep commented May 23, 2023

Addition of redirect downloads, as per matrix-org/matrix-spec-proposals#3860.

Note that I think Synapse technically can declare 1.7 without actually doing anything for this, the spec for the /download and /thumbnail endpoints have a new allow_redirect query parameter:

Indicates to the server that it may return a 307 or 308 redirect response that points at the relevant media content. When not explicitly set to true the server must return the media content itself.

Those endpoints should already ignore unknown parameters, so should be compliant.

@tulir
Copy link
Member

tulir commented May 24, 2023

Note that I think Synapse technically can declare 1.7 without actually doing anything for this

Synapse should implement following redirects when downloading media over federation, but I guess that might not be relevant for declaring support in the C-S API

@clokep
Copy link
Member Author

clokep commented May 24, 2023

Note that I think Synapse technically can declare 1.7 without actually doing anything for this

Synapse should implement following redirects when downloading media over federation, but I guess that might not be relevant for declaring support in the C-S API

Yes, that's a good point! 👍 I always forget the S-S & C-S APIs are the same for media. 😢

@clokep clokep mentioned this issue Aug 7, 2023
11 tasks
@jplatte

This comment was marked as off-topic.

@clokep

This comment was marked as off-topic.

@clokep

This comment was marked as off-topic.

@clokep
Copy link
Member Author

clokep commented Nov 28, 2023

Note that I think Synapse technically can declare 1.7 without actually doing anything for this

Synapse should implement following redirects when downloading media over federation, but I guess that might not be relevant for declaring support in the C-S API

Yes, that's a good point! 👍 I always forget the S-S & C-S APIs are the same for media. 😢

#16701 should implement following the redirects on the S-S side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants