Version 1.86 breaks Element-IOS: All texts are red

[jacotec]

Description

Synapse version 1.86 causes all texts in Element-IOS to be in red, like you are mentioned (but you aren't).

element-hq/element-ios#7601

This is highly annoying, hoping for a hotfix.

Steps to reproduce

• Upgrade Synapse from 1.85.2 to 1.86
• All messages in Element-IOS are red now

Homeserver

Own homeserver

Synapse Version

1.86.0

Installation Method

Debian packages from packages.matrix.org

Database

PostgreSQL

Workers

Single process

Platform

Ubuntu 22.04 LTS Server

Configuration

No response

Relevant log output

no relevant logs, Synapse itself is running

Anything else that would be useful to know?

[Johennes]

The client-side fix for this has been merged with matrix-org/matrix-ios-sdk#1799.

[MadLittleMods]

@Johennes Is this a spec bug, Synapse bug, client bug? Any more context you've gathered while making the client-side fix?

[Johennes]

Oh, this was a pure client issue. Before the fix, the iOS app would skip over push rule conditions it didn't know and continue with the next one.

So in

{
    "rule_id": ".m.rule.is_room_mention",
    "default": true,
    "enabled": true,
    "conditions": [
        {
            "kind": "event_property_is",
            "key": "content.m\\.mentions.room",
            "value": true
        },
        {
            "kind": "sender_notification_permission",
            "key": "room"
        }
    ],
    "actions": [
        "notify",
        {
            "set_tweak": "highlight"
        }
    ]
}

it skipped over the first condition because it doesn't know event_property_is but then still continued with the second condition. When the latter matched, it considered the whole rule matching which effectively made every message a room mention.

[Johennes]

The client fix has been released in a patch last week. So I think we can close this.