Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Delete Media on Media storage providers #16475

Open
Alkl58 opened this issue Oct 12, 2023 · 0 comments
Open

Delete Media on Media storage providers #16475

Alkl58 opened this issue Oct 12, 2023 · 0 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@Alkl58
Copy link

Alkl58 commented Oct 12, 2023

Description:

Currently the implementation for the media_storage_providers is only able to upload and download - with options whether or not to store locally uploaded files and / or to store remote media (media cache), however we can only delete local media files.

When looking at the code, we only delete local files:

There are probably some questions which have to be answered first:

  • Should the deletion be optional? (e.g. option in config)
  • Would the implementation break existing storage providers?
  • Is this "feature" even something we want?

I am personally running a server with the synapse-s3-storage-provider and noticed relatively late, that it's basically append only, meaning the s3 storage will continuously grow without being able to delete old/unused media. (Related Github Issue matrix-org/synapse-s3-storage-provider#96)

I may or may not be able to contribute, I would need to setup a dev environment for that.

@clokep clokep changed the title Feature: Delete Media on Media storage providers Delete Media on Media storage providers Oct 14, 2023
@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants