Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Tag messages don't include changelog headers #16694

Open
DMRobertson opened this issue Nov 27, 2023 · 4 comments
Open

Tag messages don't include changelog headers #16694

DMRobertson opened this issue Nov 27, 2023 · 4 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@DMRobertson
Copy link
Contributor

Before:

$ git show v1.86.0 | head -n 20
tag v1.86.0
Tagger: Mathieu Velten <[email protected]>
Date:   Tue Jun 20 17:23:48 2023 +0200

Synapse 1.86.0 (2023-06-20)
===========================

No significant changes since 1.86.0rc2.

Synapse 1.86.0rc2 (2023-06-14)
==============================

Bugfixes
--------

- Fix an error when having workers of different versions running. ([\#15774](https://github.com/matrix-org/synapse/issues/15774))

Synapse 1.86.0rc1 (2023-06-13)
==============================


After:

$ git show v1.87.0 | head -n 20
tag v1.87.0
Tagger: Olivier Wilkinson (reivilibre) <[email protected]>
Date:   Tue Jul 4 16:35:04 2023 +0100

Please note that this will be the last release of Synapse that is compatible with
Python 3.7 and earlier.
This is due to Python 3.7 now having reached End of Life; see our [deprecation policy](https://matrix-org.github.io/synapse/v1.87/deprecation_policy.html)
for more details.

- Pin `pydantic` to `^1.7.4` to avoid backwards-incompatible API changes from the 2.0.0 release.
  Resolves https://github.com/matrix-org/synapse/issues/15858.
  Contributed by @PaarthShah. ([\#15862](https://github.com/matrix-org/synapse/issues/15862))

- Split out 2022 changes from the changelog so the rendered version in GitHub doesn't timeout as much. ([\#15846](https://github.com/matrix-org/synapse/issues/15846))

- Improve `/messages` response time by avoiding backfill when we already have messages to return. ([\#15737](https://github.com/matrix-org/synapse/issues/15737))
- Add spam checker module API for logins. ([\#15838](https://github.com/matrix-org/synapse/issues/15838))

- Fix a long-standing bug where media files were served in an unsafe manner. Contributed by @joshqou. ([\#15680](https://github.com/matrix-org/synapse/issues/15680))
- Avoid invalidating a cache that was just prefilled. ([\#15758](https://github.com/matrix-org/synapse/issues/15758))

I'm guessing there was a towncrier update between v1.86.0 and v1.87.0 which changed the headings style.

@DMRobertson
Copy link
Contributor Author

See also https://stackoverflow.com/questions/2788092/start-a-git-commit-message-with-a-hashmark

Something for the release script to fix?

@clokep
Copy link
Member

clokep commented Nov 27, 2023

I'm guessing there was a towncrier update between v1.86.0 and v1.87.0 which changed the headings style.

Looks like it went from reStructuredText to Markdown?

@DMRobertson
Copy link
Contributor Author

My money is on twisted/towncrier#483

@DMRobertson
Copy link
Contributor Author

I'm guessing there was a towncrier update between v1.86.0 and v1.87.0 which changed the headings style.

$ git log --oneline v1.86.0..v1.87.0 | grep towncrier
70dc44f667 Bump towncrier from 22.12.0 to 23.6.0 (#15831)

See also https://github.com/matrix-org/matrix-spec/pull/1598/files

@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

3 participants