Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle conferences in parallel and clean them up properly #129

Open
daniel-abramov opened this issue Feb 11, 2023 · 0 comments
Open

Handle conferences in parallel and clean them up properly #129

daniel-abramov opened this issue Feb 11, 2023 · 0 comments
Labels

Comments

@daniel-abramov
Copy link
Contributor

Currently, incoming To-Device messages are handled sequentially. We use an unbounded channel to send messages to the conference. This means that we block when we send a message to the conference until the conference reads the message. This is not very good from the scalability point of view as it means that when we have multiple conferences, the slowness of a single of them would affect handling To-Device messages for others.

Also, currently, we only listen on the done channel from the conference coupled with sending the message. This means that we'll detect that the conference is over only when we try to attempt to send a new message. That might be a bit too late, so it would be better to listen to the done channel for each conference so that we can remove the conference form the map in the router once it's over.

@daniel-abramov daniel-abramov added T-Enhancement New feature or request T-Task and removed T-Enhancement New feature or request labels Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant