Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a mechanism to not allow unauthorized users to requset streams of other users without others user being aware of it #40

Open
daniel-abramov opened this issue Nov 11, 2022 · 0 comments
Labels

Comments

@daniel-abramov
Copy link
Contributor

daniel-abramov commented Nov 11, 2022

It seems like currently, we don't really check if a user who connects to the SFU has the right to participate in the call. The assumption is that everyone in the room can connect to the call (which is fair), but we provide no information to the peers about other peers being subscribed to their streams.

There have been several solutions discussed within the VoIP team:

  • Make waterfall to be an Application Service (currently it's a bot), allowing waterfall to observe messages in the room and making sure that only people who posted the state event to participate in a call can join the conference.
  • Make SFU "smarter" (traditional SFU design in which SFU is in charge of a conference and informs all connected peers about publishers, and subscribers people entering/leaving a conference).

(add if there were that were discussed and that I forgot to add here)

@daniel-abramov daniel-abramov changed the title Introduce a mechanism to not allow unauthorized users requesting streams of other users Introduce a mechanism to not allow unauthorized users to requset streams of other users without others user being aware of it Nov 11, 2022
@SimonBrandner SimonBrandner added T-Enhancement New feature or request X-Needs-Investigation and removed T-Task labels Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants