Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MID-based signaling #72

Open
daniel-abramov opened this issue Dec 12, 2022 · 0 comments
Open

Implement MID-based signaling #72

daniel-abramov opened this issue Dec 12, 2022 · 0 comments
Assignees
Labels
T-Enhancement New feature or request T-Task

Comments

@daniel-abramov
Copy link
Contributor

daniel-abramov commented Dec 12, 2022

See the rationale in a discussion here: https://github.com/vector-im/voip-internal/discussions/79

  • Essentially, the trackIDs identify a track and they are unique, but they are not guaranteed to match on both sides.
  • streamIDs identify a stream ("container" of tracks) and are not unique, but they are guaranteed to match on both sides.
  • mids identify a single transceiver/track and are not unique, but they are guaranteed to match on both sides.

Since we work on a track level and the trackID is not a sustainable option, we'll have to use mid based signaling. But since mids are not unique on their own, we'll have to use a combination of mid and some participant identifier (in our case deviceID). Then we would need to group mids that belong to a stream.

Use https://github.com/matrix-org/waterfall/pull/12/files as a reference on how it might have been implemented.

@daniel-abramov daniel-abramov added T-Enhancement New feature or request T-Task labels Dec 12, 2022
@daniel-abramov daniel-abramov self-assigned this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New feature or request T-Task
Projects
None yet
Development

No branches or pull requests

1 participant