Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_sum! cleanup #80

Closed
jarlebring opened this issue Feb 1, 2024 · 1 comment
Closed

add_sum! cleanup #80

jarlebring opened this issue Feb 1, 2024 · 1 comment

Comments

@jarlebring
Copy link
Collaborator

jarlebring commented Feb 1, 2024

Considering that add_lincomb! now can take more than two terms, the function add_sum! seems a bit redundant. There seems to be an opportunity to remove code. I think we should

  1. Go through all the uses of add_sum! and see if it can be changed to add_lincomb!
  2. Consider removing the function add_sum
  3. Consider adding a function expand_sum(graph,node): Take essentially the code in add_sum. It can take a :lincomb node and expands it as a sum each sum containing two terms.
  4. Consider removing generators/bigraph.jl (which was needed when we only had two-term version of BLAS-calls)

Point 3 should only be done if we feel it is really needed. Less is more.

@jarlebring
Copy link
Collaborator Author

I'm closing this for now. Can be reopened if we need expand sum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant