-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_sum! cleanup #80
Comments
mfasi
added a commit
that referenced
this issue
Feb 1, 2024
Merged
mfasi
added a commit
that referenced
this issue
Feb 2, 2024
mfasi
added a commit
that referenced
this issue
Feb 2, 2024
mfasi
added a commit
that referenced
this issue
Feb 2, 2024
mfasi
added a commit
that referenced
this issue
Feb 2, 2024
mfasi
added a commit
that referenced
this issue
Feb 2, 2024
mfasi
added a commit
that referenced
this issue
Feb 2, 2024
mfasi
added a commit
that referenced
this issue
Feb 2, 2024
I'm closing this for now. Can be reopened if we need expand sum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Considering that
add_lincomb!
now can take more than two terms, the functionadd_sum!
seems a bit redundant. There seems to be an opportunity to remove code. I think we shouldadd_sum!
and see if it can be changed toadd_lincomb!
add_sum
expand_sum(graph,node)
: Take essentially the code inadd_sum
. It can take a:lincomb
node and expands it as a sum each sum containing two terms.generators/bigraph.jl
(which was needed when we only had two-term version of BLAS-calls)Point 3 should only be done if we feel it is really needed. Less is more.
The text was updated successfully, but these errors were encountered: