Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements suggestion #1

Open
3 of 5 tasks
jcubic opened this issue Feb 18, 2020 · 4 comments
Open
3 of 5 tasks

Improvements suggestion #1

jcubic opened this issue Feb 18, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jcubic
Copy link

jcubic commented Feb 18, 2020

Here is list of improvements that you can add to the app:

  • Add formatter that parse Markdown to display basic formatting for projects (can help you with this)
  • Improve MacOS
    • Window drag & drop
    • add dropdown menus

  • Markdown formatter
  • DnD windows
  • Dropdown menus
    • Default menu items
    • Different menu items for active "apps"
@jcubic
Copy link
Author

jcubic commented Feb 18, 2020

You can use this weird looking code:

$.terminal.defaults.formatters = [
  [/!\[([^\]]+)\]\(([^)]+)\)/, function(_, text, url) {
    return '[[@;;;;' + url + ']' + text + ']';
  }],
  [/\[([^\]]+)\]\(([^)]+)\)/, function(_, text, url) {
    return '[[!;;;;' + url + ']' + text + ']';
  }],
  [/#+\s+(.*)/, '[[b;#fff;]$1]'],
  $.terminal.nested_formatting
]

It's list of regular expressions and replacements that will format basic markdown when you echo, like in your portfolio. (link, headers and images)

You can add command that will use options to display Markdown or html (by using option to echo formatters: false)

PS: you have error in markdown this is not valid:

![Faucet preview](techProjects/faucet.jpg "Preview")

"Preview" will be part of the src attribute (check in comment on github and click preview).

@matronator
Copy link
Owner

  • Add formatter that parse Markdown to display basic formatting for projects (can help you with this)

You can use this weird looking code:

Oh, you meant formatter in the terminal, right? Because currently I use Showdownjs to format the markdown, so I was confused at first.

I totally forgot that your terminal supports custom formatters, that would actually be better, one less dependency. Thanks, I'll get right to it!

  • Window drag & drop

I thought about this as well before I started making it, but then I got caught up in the terminal and styling the top taskbar that I kinda forgot.

  • add dropdown menus

This one is something I'm not looking forward to... Dropdowns were one of the first thing I wanted to do on this project, but then I looked at how much stuff there is in the macOS Finder menus and postponed it for later. But I definitely want to add them at some point :D

Anyways, thanks for your suggestions and your help with the formatter! And also for having such an amazing plugin!

@matronator
Copy link
Owner

Oh and about the image, are you sure it's wrong? It looks fine to me.

mdsyntax

I copied the code from the Markdown Cheatsheet

@jcubic
Copy link
Author

jcubic commented Feb 18, 2020

Oh, I was wrong, so the formatter need to be changed a bit. To have title it require little bit more work, but it's also possible with terminal formatters.

@matronator matronator added the enhancement New feature or request label Sep 22, 2020
@matronator matronator self-assigned this Sep 22, 2020
@matronator matronator added this to the UI milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants