Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct URL in address bar and share button #237

Open
Snailedlt opened this issue May 8, 2024 · 1 comment
Open

Show correct URL in address bar and share button #237

Snailedlt opened this issue May 8, 2024 · 1 comment

Comments

@Snailedlt
Copy link

Snailedlt commented May 8, 2024

I've only recently noticed that there's a share button.
Personally I prefer just copying the URL from the address bar whenever I want to share a website with someone. This is because every website has a different location for their share button, but the URL is always visible in the browser's address bar.
However on this website that's not possible because the address bar does not have the link that I want to share.

For example if I wanted to share the Minimal Template example to showcase the difference between svelte and react the URL I want is: https://component-party.dev/compare/svelte4-vs-react#minimal-template. Now if I click the share button I get this URL: https://component-party.dev/compare/svelte4-vs-react, but if I copy the URL from the address bar I get this URL: https://component-party.dev/#minimal-template.
Notice how both of the URLs are missing crucial portions that are needed to showcase what I want to share.

So what needs fixing?

  1. The URL generated by the share button should append the Id of the selected example... for example #minimal-template
  2. The URL in the address bare should reflect the selected languages.

TLDR; If I select Svelte 4 and React, and click on the * Minimal Template*, both clicking on the share button and the copying the URL in the address bar should result in this URL: https://component-party.dev/compare/svelte4-vs-react#minimal-template

@sheriffderek
Copy link

The way this is worded feels a bit confusing ^^

But I think what I'm here to ask about is the same idea.

I want to be able to share the page - but with the selections I've chooses (like React/Vue)

It's not clear to me that the button will do this -- because the URL doesn't show this.

That might be in the form of query strings ...com?languages=react,vue

...com?languages=react,vue&section=templating or something -- (or the whole URL)

Anyway, +1 for a classic way to direct people to the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants