Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibly overriding environment variables? #6

Closed
megantaylor opened this issue Jun 11, 2024 · 3 comments
Closed

possibly overriding environment variables? #6

megantaylor opened this issue Jun 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@megantaylor
Copy link

so excited and grateful for this plugin, thank you so much!

i installed and set up the plugin following the method described here: reduxjs/redux-devtools#1533 (comment) and it works!

however, i am now getting typescript errors about all of my environment variables. i poked around, and saw

declare global {
  const process: {
    env: {
      NODE_ENV: "development" | "production";
    };
  };
}

in src/index.ts.

looking at some other expo dev plugins (https://github.com/expo/dev-plugins), i notice that they don't do this, and assume the environment variables will be available via metro transform plugins.

so it seems to me as though that global declaration is overriding the env variables i have set up? am i totally off base? is there something i can do on my end to fix this?

@matt-oakes
Copy link
Owner

Hi there. Thanks for reporting this.

So I can look into this a bit easier, can you provide a minimal reproducable example of the issue? A Github repo with an Expo app which does nothing but show this issue would be perfect.

@matt-oakes matt-oakes added waiting for response Waiting for a response to be able to deal with the issue or PR bug Something isn't working labels Jun 12, 2024
@zakwalters
Copy link
Contributor

Forgot to check the issues before opening, but #7 has a fix for this.

@matt-oakes matt-oakes added pr open A PR has been opened to resolve this issue and removed waiting for response Waiting for a response to be able to deal with the issue or PR labels Jun 14, 2024
@matt-oakes
Copy link
Owner

Fixed in v0.2.0. Thank you for reporting this.

@matt-oakes matt-oakes removed the pr open A PR has been opened to resolve this issue label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants