Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another compressor support #13

Closed
abhi1693 opened this issue Jan 29, 2017 · 4 comments
Closed

Add another compressor support #13

abhi1693 opened this issue Jan 29, 2017 · 4 comments

Comments

@abhi1693
Copy link

abhi1693 commented Jan 29, 2017

TniyPNG is a great addon but it is a paid option which makes it difficult to use if you have many images on the website. I think you should implement a free library which will compress the the images and is as good as TinyPNG.

For this, I think resmush.it/ is a good candidate. Please look into it. I tried to integrate it with your library but I ran into some issues since I'm new to OctoberCMS and Laravel.

Try this link

@matt-pawley
Copy link
Owner

Hey @abhi1693

Appreciate the feedback. Will have a play around with the link you supplied, a forever free solution would be ideal. Will get back to you when I've had chance to progress further with this.

@matteotrubini
Copy link
Collaborator

@abhi1693 can you open a PR? I would be happy to review and merge it.

@matteotrubini
Copy link
Collaborator

This plugin is being migrated to core (see #55), so we are trying to figure out what issues are still relevant to invite to reopen them in core.

Issues that will remain inactive in next 30 days will be closed.

@LukeTowers
Copy link
Contributor

@abhi1693 see https://github.com/LukeTowers/oc-tinypng-plugin/blob/master/Plugin.php for how you can implement this with the new core functionality. @matteotrubini you can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants