Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{action}-password route naming convention #23

Open
maxterry opened this issue Apr 6, 2020 · 1 comment
Open

{action}-password route naming convention #23

maxterry opened this issue Apr 6, 2020 · 1 comment

Comments

@maxterry
Copy link
Contributor

maxterry commented Apr 6, 2020

Currently all routes follow the {action}-password convention, except one.

password-reset should shift to reset-password for consistency.

https://github.com/mattboutet/user-pal/blob/master/lib/services/email.js#L30
https://github.com/mattboutet/user-pal/blob/master/lib/services/user.js#L144

@mattboutet
Copy link
Owner

Just to clarify: the api routes all follow the same action-password pattern (e.g. /users/reset-password) the thing that is going to change here is the link we send to the front end (https://github.com/mattboutet/user-pal/blob/master/lib/services/user.js#L144) and, in the interest of consistency, the email templates associated with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants