Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update cache configuration / usage #387

Open
dutterbutter opened this issue Nov 18, 2024 · 0 comments
Open

refactor: update cache configuration / usage #387

dutterbutter opened this issue Nov 18, 2024 · 0 comments

Comments

@dutterbutter
Copy link
Collaborator

Description:

The cache_config field in the ForkDetails structure is currently being cloned during initialization. This is explicitly noted as a temporary solution in the following code:

cache_config: cache_config.clone(), // TODO: This is a temporary solution, we should avoid cloning the cache config here. We should look to refactor how cache is being configured / used as it currently feels a bit too rigid.

The current approach leads to unnecessary duplication and rigidness in how the cache configuration is managed across the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant