feat: enable compilation with CUDA stubs via the ZKSYNC_USE_CUDA_STUBS environment variable
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
To make the changed discoverable, you can mention RUSTFLAGS and env var here, e.g. "Alternatively, if you don't have a compatible nvidia GPU, you can compile the project without GPU support. To do that, either set RUSTFLAGS to (...) or set the environment variable (...). Doing so will result in stubs being used instead of actual code that works with GPU. Note that you will be able to compile the code, but won't be able to run it.".
robik75
force-pushed
the
rr/no-cuda-part-2
branch
from
a680433
to
d5667b8
Compare
EmilLuta
approved these changes
Sep 24, 2024
EmilLuta
pushed a commit
that referenced
this pull request
Sep 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.150.9](v0.150.8...v0.150.9) (2024-09-24) ### Features * enable compilation with CUDA stubs via the `ZKSYNC_USE_CUDA_STUBS` environment variable ([#29](#29)) ([f77ff80](f77ff80)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR is a follow-up to
matter-labs/era-cuda#9
matter-labs/era-boojum-cuda#36
making it possible to enable the compilation with CUDA stubs by setting the environment variable
ZKSYNC_USE_CUDA_STUBSto1ortrueoryesin any capitalization in addition to theno_cudaconfiguration flag.Why ❔
Other way to enable the compilation with stubs besides a configuration flag is desirable.
Checklist
cargo fmtand linted viacargo clippy.