Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config updates should be processed in OnConfigurationChange #77

Open
mickmister opened this issue Mar 28, 2023 · 0 comments
Open

Config updates should be processed in OnConfigurationChange #77

mickmister opened this issue Mar 28, 2023 · 0 comments
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Contributor

At the moment, all of the config processing logic is done in OnActivate. It should also be handled in OnConfigurationChange in case the admin changes settings while the plugin is running.

Originally posted by @mickmister in #75 (comment)
@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Tech/Go Type/Enhancement New feature or improvement of existing feature labels Mar 28, 2023
@mickmister mickmister mentioned this issue Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mickmister