Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle React warnings regarding non-DOM properties #46

Open
mickmister opened this issue Apr 28, 2020 · 5 comments
Open

Handle React warnings regarding non-DOM properties #46

mickmister opened this issue Apr 28, 2020 · 5 comments
Labels
Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Task A general task Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Contributor

There are warnings being printed to the console in the browser when running /confluence subscribe, like the following:

Warning: React does not recognize the `addValidation` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `addvalidation` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

There are some properties being passed to DOM elements that are part of the plugin's logic, that are not supported by the native DOM elements. The task here is to avoid sending these props to the DOM elements.

image

@mickmister mickmister added Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Type/Task A general task Tech/ReactJS Up For Grabs Ready for help from the community. Removed when someone volunteers labels Apr 28, 2020
@Ako92
Copy link

Ako92 commented Aug 1, 2020

i can do that. may i make a pr?

@mickmister
Copy link
Contributor Author

@Ako92 Absolutely! Sorry for my late response here 🙂

@mickmister mickmister removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Aug 5, 2020
@Ako92
Copy link

Ako92 commented Aug 7, 2020

is there any test environment??
What should I do to have a test environment ?

@mickmister
Copy link
Contributor Author

@Ako92 You can follow the steps here to set up your development environment. In order to deploy your plugin, you can set the following environment variables, then run make deploy in the root directory of the plugin repo after each change you want to test.

export MM_SERVICESETTINGS_SITEURL=http://localhost:8065
export MM_ADMIN_USERNAME=(your username)
export MM_ADMIN_PASSWORD=(your password)

@jfrerich
Copy link
Contributor

This issue appears stale and I’m adding the Up For Grabs label. If work is ongoing, please remove the label. If there is an existing PR, please also link it to the issue. Thanks!

@jfrerich jfrerich added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Task A general task Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

5 participants