Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyrillic words, how to? #32

Open
iandriyanov opened this issue May 4, 2021 · 5 comments
Open

Cyrillic words, how to? #32

iandriyanov opened this issue May 4, 2021 · 5 comments
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@iandriyanov
Copy link

How to explain russian (cyrillic) words?
@hanzei
Copy link
Contributor

hanzei commented May 4, 2021

The plugin allows to filter words based on a regex. Hence, you need to create one that filters out the characters you don't want.

@hanzei hanzei added the Type/Question Further information is requested label May 4, 2021
@iandriyanov
Copy link
Author

image
I tried to russian words:

  • Without encoding
  • Encoding utf8 with %u, \u
  • KOI8-R
  • Windows1251

But as you can see on screenshot, filtering doesn't work, latin words - ok

@iandriyanov
Copy link
Author

@hanzei What You think?

@hanzei
Copy link
Contributor

hanzei commented May 7, 2021

I can reproduce your issue locally. I suppose it's due the use of \b in https://github.com/mattermost/mattermost-plugin-profanity-filter/blob/e5b27a817e88bd98f1eb8d0722dec0d6ba27ee0c/server/configuration.go#L111. Right now, this plugin doesn't support non-ASCI words. Fixes are welcome.

@hanzei hanzei added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Type/Question Further information is requested labels May 7, 2021
@bvdcode
Copy link

bvdcode commented Jul 17, 2023

I confirm this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iandriyanov @cpanato @hanzei @bvdcode