Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "new" commands to "create" #34

Open
hanzei opened this issue May 7, 2020 · 0 comments
Open

Rename "new" commands to "create" #34

hanzei opened this issue May 7, 2020 · 0 comments
Labels
Type/Enhancement New feature or improvement of existing feature

Comments

@hanzei
Copy link
Contributor

hanzei commented May 7, 2020

This is a great question. In the go code, I try to have the convention of "new" is usually just a memory allocation/simple init, fast and no error possible. "make" can fail. "create" is for creating new persisted entities.

However, I did not stick with the convention for the commands (why??) and in this case the function name is reflective of the command.

Originally posted by @levb in #27

@hanzei hanzei added the Type/Enhancement New feature or improvement of existing feature label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

1 participant