Update Webex Logo

[Chess-h]

Hello, would it be possible to update the Webex logo to the new "W" logo? I would be happy to provide what ever image is needed to make this change.

Thank you so much for your help and support.

[mickmister]

Hi @Chess-h, thanks for filing this issue, and thank you for your interest in contributing 💯

There are a few places where the logo is used if you would like to take a look:

• Marketplace icon https://github.com/mattermost/mattermost-plugin-webex/blob/master/assets/icon.svg
• User profile icon https://github.com/mattermost/mattermost-plugin-webex/blob/master/assets/profile.png
• Channel header icon (For older servers. Probably doesn't need to be updated.) https://github.com/mattermost/mattermost-plugin-webex/blob/master/webapp/src/constants/svgs.js
• Apps Bar icon https://github.com/mattermost/mattermost-plugin-webex/blob/master/public/app-bar-icon.png

[Chess-h]

@mickmister, thank you for all the links, i found a few when poking around but i was missing a few. Would you like me to provide the images for each location or start a new branch and update the locations?

[mickmister]

@Chess-h It would be super helpful if you can add the images to a separate branch, and also provide screenshots of the changes to ensure it all works correctly. Are you able to do this?

Thanks again for your attention to detail 👍

[Chess-h]

hi @mickmister, i have reached out to my team and there is someone who would be happy to update the logos. What is the best way to get him engaged. I saw on your "Mattermost contribution checklist" there is a process, would this need to be followed for this plugin?

[mickmister]

@Chess-h A simple PR should be all that's needed 👍 Here are the docs for setting up the development environment for plugins https://developers.mattermost.com/integrate/plugins/developer-setup

[jmcrtp]

Hello,

I'm trying to follow the above link on an Ubuntu system and it is failing at this step. Please advise. Thank you.

ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex$ cd server/
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex/server$ make run-server
make: *** No rule to make target 'run-server'.  Stop.
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex/server$ 

[mickmister]

@jmcrtp It seems you're trying to run the run-server command (meant to start a Mattermost server) inside of a plugin repository. If you're trying to run the MM server, you need to run that command in the mattermost repository in its server folder

[jmcrtp]

At the link posted immediately above my post, there is a link to setup server, then web app. Under the first server link I have been following the steps which I assume are intended to setup a server for this. I followed steps 1-8, then step 9 states to start the server:

cd server
make run-server

I did run this in the mattermost repository server directory as the doc intends, am I missing something here, or is there a better/updated document to follow? I'm simply trying to create a PR with an updated logo.

ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex$ pwd
~/Side-Projects/mattermost-plugin-webex
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex$ ls
assets  build  CODEOWNERS  go.mod  go.sum  LICENSE  Makefile  mattermost  plugin.json  public  README.md  server  venv  webapp
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex$ cd server
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex/server$ make run-server
make: *** No rule to make target 'run-server'.  Stop.
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex/server$ curl http://localhost:8065/api/v4/system/ping
curl: (7) Failed to connect to localhost port 8065 after 0 ms: Connection refused
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex/server$ 

Again to recap, I followed steps 1-8 of the server setup link (installed build-essential, go, nvm).. This step fails and the validation step following also fails, as it should. Trying to get this installed before I can run.. Thank you.

[mickmister]

I believe the error you're seeing is because you're running make run-server in the plugin project, but there is no run-server make target in the plugin project. I'm inferring this from these two lines in your output:

ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex$ cd server
ubuntu-jumpbox:~/Side-Projects/mattermost-plugin-webex/server$ make run-server

You'll need to run this in the main mattermost repo instead https://github.com/mattermost/mattermost. I recommend running make run instead of make run-server if it's the first time you're running the server, so the frontend can also be compiled.

To deploy the plugin after running the server, you can follow the instructions here https://developers.mattermost.com/integrate/plugins/developer-setup

[mickmister]

@jmcrtp I meant to mention you in my comment above. Commenting again to fix that