From 035c9799145013417460d3494463a4b564f022ce Mon Sep 17 00:00:00 2001 From: kshitij katiyar Date: Mon, 23 Sep 2024 13:26:10 +0530 Subject: [PATCH] [MM-794]: review fixes --- server/client.go | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/server/client.go b/server/client.go index fbb6e1a62..5a7ce56bc 100644 --- a/server/client.go +++ b/server/client.go @@ -333,28 +333,27 @@ func MakeCreateIssueURL(instance Instance, project *jira.Project, issue *jira.Is } // add custom fields - for k, v := range issue.Fields.Unknowns { - switch vTyped := v.(type) { + for key, field := range issue.Fields.Unknowns { + switch fieldTyped := field.(type) { case string: - q.Add(k, vTyped) + q.Add(key, fieldTyped) case map[string]interface{}: - if id, ok := vTyped["id"].(string); ok { - q.Add(k, id) + if id, ok := fieldTyped["id"].(string); ok { + q.Add(key, id) } case []interface{}: - for _, item1 := range vTyped { - switch vTyped2 := item1.(type) { + for _, element := range fieldTyped { + switch elementTyped := element.(type) { case string: - - q.Add(k, vTyped2) + q.Add(key, elementTyped) case map[string]interface{}: - if id, ok := vTyped2["id"].(string); ok { - q.Add(k, id) + if id, ok := elementTyped["id"].(string); ok { + q.Add(key, id) } case []map[string]interface{}: - for _, item := range vTyped2 { - if id, ok := item["id"].(string); ok { - q.Add(k, id) + for _, mapWithID := range elementTyped { + if id, ok := mapWithID["id"].(string); ok { + q.Add(key, id) } } }