Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support importing profile pictures from Slack #53

Open
wetneb opened this issue Sep 11, 2024 · 3 comments · May be fixed by #57
Open

Support importing profile pictures from Slack #53

wetneb opened this issue Sep 11, 2024 · 3 comments · May be fixed by #57

Comments

@wetneb
Copy link
Contributor

wetneb commented Sep 11, 2024

When importing a Slack dump, profile pictures are not imported.

It would be nice to have support for this. The downloading of the images could be added to the slack-advanced-exporter (to match the workflow used for the attachments) or let mmetl download them directly on the fly.
@isacikgoz
Copy link
Member

Thanks for the feedback @wetneb added this to our internal backlog!

@wetneb
Copy link
Contributor Author

wetneb commented Sep 12, 2024

@isacikgoz do you have any thoughts on whether the downloading should happen in mmetl or in slack-advanced-exporter?

So far I have an implementation which does the downloading in slack-advanced-exporter, happy to contribute it as a PR.

@isacikgoz
Copy link
Member

@wetneb probably slack-advanced-exporter would be the best tool for that as it handles all the export logic. mmetl is more like a conversion tool.

wetneb added a commit to wetneb/mmetl that referenced this issue Sep 20, 2024
@wetneb
Import profile pictures from Slack.
dbfae1d 
Closes mattermost#53.

This expects a Slack zip archive produced by slack-advanced-exporter
with the additional PR:
grundleborg/slack-advanced-exporter#37
@wetneb wetneb linked a pull request Sep 20, 2024 that will close this issue
Draft
wetneb added a commit to wetneb/mmetl that referenced this issue Oct 14, 2024
@wetneb
Import profile pictures from Slack. Closes mattermost#53.
f6f6bb6
wetneb added a commit to wetneb/mmetl that referenced this issue Oct 15, 2024
@wetneb
Import profile pictures from Slack.
956b26f 
Closes mattermost#53.

This expects a Slack zip archive produced by slack-advanced-exporter
with the additional PR:
grundleborg/slack-advanced-exporter#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MM-60513] Import profile pictures from Slack. wetneb/mmetl
2 participants
@wetneb @isacikgoz