Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxWebsocketMessageSize is hard-coded #93

Open
hoytech opened this issue Aug 3, 2018 · 5 comments
Open

MaxWebsocketMessageSize is hard-coded #93

hoytech opened this issue Aug 3, 2018 · 5 comments

Comments

@hoytech
Copy link
Contributor

hoytech commented Aug 3, 2018

If you want bigger inbound messages you need to bump this up in src/main/c/Connection.cpp (and maybe also ReadWriteBufferSize -- dunno I did both), and then recompile library.

@mattgodbolt
Copy link
Owner

Good point! (wow, how big are your messages!) We should make this configurable though :)

@hoytech
Copy link
Contributor Author

hoytech commented Aug 3, 2018

Hehe usually a lot smaller but in one case about 500 bytes bigger than that limit, which is how I noticed this :)

Outbound messages are sometimes 1M pre-compression and no problems there, this only seems to affect in-bound.

@A-J-Bauer
Copy link

A-J-Bauer commented Dec 3, 2018

I also noticed this when trying to send a large text file.
For testing I changed ReadWriteBufferSize, MaxWebsocketMessageSize in Connection.cpp to 256 * 1024.

This works for Firefox. Chrome however seems to send chunks for large strings. Presumably setting FIN bit 1 for the first, FIN bit 0 for following and FIN bit 1 for the last one. This however is not supported in HybiPacketDecoder.cpp (Line 46).

@stazio
Copy link

stazio commented Nov 18, 2020

What is the state of this? Seasocks hangs for that one connection for me if I try to send too big of a string.

@A-J-Bauer
Copy link

You can check out my Pull Request "Support for fragmented Messages" (which I couldn't get thru test insanity) and see if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants