-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaxWebsocketMessageSize is hard-coded #93
Comments
Good point! (wow, how big are your messages!) We should make this configurable though :) |
Hehe usually a lot smaller but in one case about 500 bytes bigger than that limit, which is how I noticed this :) Outbound messages are sometimes 1M pre-compression and no problems there, this only seems to affect in-bound. |
I also noticed this when trying to send a large text file. This works for Firefox. Chrome however seems to send chunks for large strings. Presumably setting FIN bit 1 for the first, FIN bit 0 for following and FIN bit 1 for the last one. This however is not supported in HybiPacketDecoder.cpp (Line 46). |
What is the state of this? Seasocks hangs for that one connection for me if I try to send too big of a string. |
You can check out my Pull Request "Support for fragmented Messages" (which I couldn't get thru test insanity) and see if it works for you. |
If you want bigger inbound messages you need to bump this up in
src/main/c/Connection.cpp
(and maybe alsoReadWriteBufferSize
-- dunno I did both), and then recompile library.The text was updated successfully, but these errors were encountered: