Refactor dependency discovery to handle multiple architectures #230
+284
−141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_dependencies
and what it calls has been refactored to handle dependencies organized by architecture. Delocate is now aware of multiple architectures and should handle the most common cases where libraries depend on different things depending on their architecture. Fixes #153 Fixes #154_check_ignore_archs
is being phased out. Most of the work was inget_dependencies
,get_install_names
, andget_rpaths
. I made new private versions of some of these so that they could have an updated return value needed to track the architecture.Adding
-arch all
to allotool
calls makesotool
act like it does in later MacOS versions. The tests added in #140 no longer expectNotImplementedError
. Fixing this also allows testing on newer MacOS runners which I've added. Closes #137I tried to switch functions which return library data to return
PurePosixPath
but this causes it to remove trailing slashes on folders and the functions which edit library data need the strings be match exactly, so there's no point in switching those functions over to return Path types. I did update much of what I touched to use pathlib inputs though.This PR is a mess so far. I'll likely squash this before merging.
Pull Request Checklist