-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow copying files into an already existing directory #199
Comments
here is the code in question |
If I recall correctly it was a safety check since I wasn't sure how to handle a situation where a library references an external dependency but that dependency already exists inside the package. Without this check the internal file would've been silently clobbered. What does |
At the very least I could probably change this into a warning instead of an error. |
I'm not sure. That would be a strange situation, but then maybe the check should be more fine-grained. If I understand correctly the code currently will error out if the directory pre-exists. I could make a PR to check my assumptions, if you think it makes sense. |
You're right. It seems it'd delete the folders contents and start over if this check didn't stop it. I'm wondering if that's actually desirable or what the edge cases are. Looking into it more, I did not write this other than to mess up converting it to an f-string. This check was here for decades. Original code for comparision. I suspect it's surviving multiple refactors because everyone including me has been too afraid to touch it. |
Describe the bug
A clear and concise description of what the bug is.
I would like to ship a build of OpenBLAS as a wheel. On posix, the build ships a
libscipy-openblas.so
which depends onlibgfortran.so
andlibquadmath.so
. The scipy-openblas shared object is the target bundled in the wheel underlib
, then auditwheel/delocate is used to copylibgfortran
andlibquadmath
into thelib
directory. On auditwheel I can do this using--lib-sdir /lib
. But in delocate, usingdelocate-wheel -L /lib
raises an error here (note there is also a typo in the use of f-string, the f should be outside the quotes):delocate/delocate/delocating.py
Lines 684 to 687 in eaba43d
To Reproduce
Steps used to reproduce the behavior, such as the delocate commands used.
Expected behavior
A clear and concise description of what you expected to happen.
Wheels used
If a wheel is involved then consider attaching the original wheel (before being delocated) or linking to the repository where the original wheel can be created.
Platform (please complete the following information):
Additional context
Add any other context about the problem here.
What was the reasoning for wanting a clean directory?
The text was updated successfully, but these errors were encountered: